Flyspray::

FS#80: object_booking month view taking 60+ seconds to render

Ian Thompson — 2026-03-26T16:42:56Z

The function day_summary() was calling check_no_overlap() for every hour of every day in the calendar.
This resulted in approximately 30 days × up to 24 hours ≈ 700+ calls per page load.
Each call to check_no_overlap() executed multiple database queries (booking_object, lab_equipment, labs, proximity checks, overlap checks, etc.), leading to an estimated 5,000–6,000 database queries per page render.

The function check_no_overlap() is intended for booking validation, not for display logic.

Resolution:
Replaced calls to check_no_overlap() in the calendar rendering with a lightweight in-memory overlap check - function has_overlap($entriesForDay, $start, $end).

Changes made:
Refactored/replaced showMonth() with showMonth_2() to minimise queries (old code still present for checking if needed)
Added has_overlap() to check booking clashes using the preloaded $entries array
Updated day_summary_2() to use has_overlap() instead of check_no_overlap()
Updated calling code to pass daily booking entries into day_summary_2()

Result:
Page load time reduced from approximately 75 seconds to 0.2 seconds, redundant database queries eliminated.
Month view now uses a single query with in-memory processing.

FS#79: multiday bookings crossing months were being overcharged in BIF report

Ian Thompson — 2026-03-05T16:14:18Z

multi-day bookings that were > month, or crossed the month boundary were given an hours value for the entire booking instead of the time used in the month (or date range) requested for the BIF report. Code updated to limit the charge/hours to the max in the month.

FS#78: include custom booking fields to email confirmation

Ian Thompson — 2026-02-23T14:23:36Z

update email confirmation sent to booking manager to include any custom booking fields

FS#77: mark equipment as invisible

Ian Thompson — 2026-02-11T14:59:01Z

add a flag to allow kit to be hidden from regular users, but still visible to equipment owner/editors - allow kit history/data to remain but regular users no longer see it.

- combo of hide from search/unbookable?
- clear any entries in user watchlists

FS#76: BIF reports wrong contents

Ian Thompson — 2026-02-05T12:00:07Z

BIF reports containing wrong data. The cleanFileName function was cutting the filename off at 35 characters, so longer lab names were being shortened and as Bath have similar, long-named labs, this was resulting in the same filename for multiple facilities and cached files resulting in the wrong data in BIF downloads.

Fix: updated cleanFileName to default to 120 chars - 39 limit was from legacy need to restrice filename length elsewhere.
Fix: updated charging.php as it was stripping the / from tempFiles/filename.csv resulting in files being stored outside of the tempFiles directory

FS#75: Batch service orders - flag any project code that has expired

Ian Thompson — 2026-01-30T11:39:26Z

Batch service orders - flag any project code that has expired

When a user does a batch upload, check each project is still valid, else highlight it so the user can change it.

FS#74: booking not showing on calendar

Ian Thompson — 2025-11-05T13:01:24Z

https://www.ulabequipment.com/equipment.php?ID=6506

had a booking on 26/10/2025 18:00 to 00:00 that wasn't displaying so user couldn't delete it. Booking was immediately after booking from 08:00 to 18:00. Changing the end time to 23:00 or earlier will make the booking display again.

Fixed for user by manually deleting from the database so they can run BIF report

same happens on DEV:
https://www.dev.ulabequipment.com/booking/weekview.php?object=3889 (view 26th Oct 2025)

FS#73: BIF report by analysis code

Ian Thompson — 2025-10-24T13:30:22Z

add tool that allows users to generate BIF report using analysis code - use substring of internal ID on each equipment item e.g.
CRFCTMSS0001

User may want all CRFCTMSSxxxx equipment bookings
→ generate BIF

Can re-use charging.php
- add new branch to _GET['lab'] / _GET['object'] / _GET['multi'] to check for _GET['analysis_code']
- rest of code should work without too much modification

need page/tool to get user to select analysis code substring to generate the BIF

FS#72: Add charity option as cost category

Ian Thompson — 2025-10-17T15:20:51Z

extends FEC option previous asked for so now have 3 cost categories (for Bath/ Fin module users)

$costCategory=array("0"⇒"Internal", "1"⇒"FEC", "2"⇒"Charity");

updates to
- project_codes.php [done dev/live]
- make_bookable.php > charging tab [done on dev]
- project_codes/charging.php [done on dev]

needs testing before going to live [testing complete]

moved to live [done]

FS#71: booking list for non-finance user

Ian Thompson — 2025-08-15T13:28:17Z

Bath have non-Finance users who want to have a 'list' view of all bookings on an item of equipment, including the project code. Need ability to modify the project code in the list - driven by need to update any/all TMP_UNKNOWN project codes used at time of booking to actual project codes at month end prior to running BIF report.

Would be useful for other users to have a list view of bookings?